(v2) migrate to v2 packages #408
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This drops the dependency on termenv and replaces it with lipgloss/v2. It breaks the API by dropping termenv colorprofiles and removing the `WithColorProfile` option.
andreynering
approved these changes
Mar 27, 2025
Member
andreynering
left a comment
andreynering
left a comment
There was a problem hiding this comment.
This will probably add some conflicts to #406, but I can handle those.
* refactor(ansi): drop reflow and use cellbuf.Wrap This drops muesli/reflow in favor of custom IndenWriter and PaddingWriter. It also uses cellbuf.Wrap instead of wordwrap.NewWriter to keep track of style and link changes when wrapping. Fixes: #149 Related: #237 * fix(ansi): remove unused overline style * chore: update testdata
Signed-off-by: Carlos Alexandro Becker <[email protected]>
This adds support for OSC 8 hyperlinks. It enables wrapped urls to be clickable and hoverable in the terminal.
This purify the Glamour API by removing the auto style feature and making the dark style the default. Glamour no longer needs to query the terminal background to determine the style to use. Querying the terminal is now part of Lip Gloss v2.
11 tasks
Member
|
@aymanbagabas FYI, I just merged the table links work into this branch. |
WithAutoStyle was removed in cd9a02a
As explained in charmbracelet/x#518 this is performance critical for complex applications such as `crush`.
Signed-off-by: Carlos Alexandro Becker <[email protected]>
meowgorithm
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the dependency on termenv and replaces it with lipgloss/v2. It breaks the API by dropping termenv colorprofiles and removing the
WithColorProfileoption.reflow/indent(v2) refactor ansi and drop reflow #409reflow/padding(v2) refactor ansi and drop reflow #409