feat(tree): support width and indenter styling #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caarlos0
approved these changes
Dec 3, 2024
|
about the breaking change, I think its a fair one. We are soon to release v2, so maybe we could pack it there, as it is already a breaking change release. |
aymanbagabas
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Hi @dlvhdr,
Thank you for working on it. It looks good overall!
Before merging:
- Can you target the
v2-expbranch, rebase and ideally squash on a single (or a few) commits? - Ensure the CI is passing for tests and lint.
- I made a couple of comments for small improvements on the examples.
This was referenced Apr 10, 2025
docs: fix WIP chore: tidy chore: cleanup + docs chore: fix lint
dlvhdr
force-pushed
the
dlvhdr/tree-improvemnts
branch
from
a883e66 to
68be6a5
Compare
|
@andreynering let me know if this requires further changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the stuff I've been implementing on charmbracelet/bubbles#639 should go into lipgloss. This would help simplify the bubble code and is better for separating the rendering logic into lipgloss itself.
This PR adds two things:
I've also wrote a new example to show what this enables.
TODO: check this against my tree bubble
Warning
This does introduce a "breaking change", not in the API but:
Trees that have subtrees with their own renderers, meaning they set a custom item/enumerator style, will need to now also set an indenter style, if they want to keep a consistent indentation styling.
If they don't set one the default empty style is used and it can look weird to suddenly have 2 kinds of indentation stylings.
Previously this was solved by using the enumerator style.