(v2) feat: add underline style and color #491
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreynering
approved these changes
Mar 13, 2025
aymanbagabas
force-pushed
the
v2-underline
branch
2 times, most recently
from
687d00d to
1b42b6d
Compare
This adds support for setting the underline style and color. The underline style can be set to single, double, curly, dotted, or dashed. The color of the underline can be set to any color. See https://sw.kovidgoyal.net/kitty/underlines/
aymanbagabas
force-pushed
the
v2-underline
branch
from
1b42b6d to
5e542b8
Compare
raphamorim
approved these changes
Mar 13, 2025
aymanbagabas
changed the title
|
This looks good, though we may want to switch the adjective-noun order on the costs for better completions with LSPs: // Before
NoUnderline
SingleUnderline
CurlyUnderline
// After
UnderlineNone
UnderlineSingle
UnderlineCurlyOn the other hand, we already have |
caarlos0
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for setting the underline style and color. The underline style can be set to single, double, curly, dotted, or dashed. The color of the underline can be set to any color.
See https://sw.kovidgoyal.net/kitty/underlines/
Fixes: #488