feat: add optional skip
argument to Helper
function
#175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
The current
Helper
function is hardcoded to only skip the immediate function that called it. This makes it really unergonomic to use in an abstraction.I have an abstraction type which provides a bunch of convenience methods, e.g. extracts known values from
context.Context
and passes them as attributes to the various log functions. This abstraction also manages multiple different instances ofLogger
under the hood. It all works quite well, except when it comes toHelper
.Broken abstraction
Working but unergonomic abstraction
The solution
The internal
helper
function already takes askip
argument that would solve this issue. The public function doesn't yet expose this and that is exactly what this PR does.In order to achieve backwards compatibility, the
skip
argument will be optional by making the publicHelper
a variadic function.Ergonomic abstraction achieved