Skip to content

Conversation

@jficz
Copy link
Contributor

@jficz jficz commented Mar 1, 2025

Adds --plaintext flag which allows sending
e-mails in plaintext with SMTP method.

Not implemented for the Resend method.

Fixes (partially?) #115

@jficz
Copy link
Contributor Author

jficz commented Apr 13, 2025

@aymanbagabas @andreynering @raphamorim
politely requesting a review :) Sorry for the ping, not sure what's your review process

@aymanbagabas
Copy link
Member

Hi @jficz, this looks good!

Could you add POP_SMTP_PLAINTEXT=bool so that this option can be controlled by environment variables?

Copy link
Member

@raphamorim raphamorim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt

@jficz
Copy link
Contributor Author

jficz commented Apr 15, 2025

Could you add POP_SMTP_PLAINTEXT=bool

sure, gimme a day or two

Adds `--plaintext` flag which allows sending
e-mails in plaintext with SMTP method.

Also adds counterpart POP_PLAINTEXT.

Not implemented for the Resend method.
@jficz
Copy link
Contributor Author

jficz commented Apr 15, 2025

@aymanbagabas added as POP_PLAINTEXTas, strictly speaking, it doesn't have anything to do with SMTP (as in the protocol)

@jficz
Copy link
Contributor Author

jficz commented Apr 15, 2025

also, any chance of a release with this feat ?

@aymanbagabas
Copy link
Member

@aymanbagabas added as POP_PLAINTEXTas, strictly speaking, it doesn't have anything to do with SMTP (as in the protocol)

Perfect!

Could you add Resend support as well? With Resend, we can omit the HTML version of the message when using plaintext

@jficz
Copy link
Contributor Author

jficz commented Apr 16, 2025

The reason I did not implement this for Resend is that, tbh, I did not really understand the code. I can take look but that will take more time.

@jficz
Copy link
Contributor Author

jficz commented Apr 16, 2025

@aymanbagabas tried in e1e08d4 but I have absolutely no idea if this will work 🤷‍♂️

I don't really understand the unsafe condition or how resend.SendEmailRequest works. Assuming it just ignores Html if the string is empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants