-
Notifications
You must be signed in to change notification settings - Fork 65
feat: Allow plaintext e-mails for SMTP #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@aymanbagabas @andreynering @raphamorim |
|
Hi @jficz, this looks good! Could you add |
raphamorim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgmt
sure, gimme a day or two |
Adds `--plaintext` flag which allows sending e-mails in plaintext with SMTP method. Also adds counterpart POP_PLAINTEXT. Not implemented for the Resend method.
|
@aymanbagabas added as |
|
also, any chance of a release with this feat ? |
Perfect! Could you add Resend support as well? With Resend, we can omit the HTML version of the message when using |
|
The reason I did not implement this for Resend is that, tbh, I did not really understand the code. I can take look but that will take more time. |
|
@aymanbagabas tried in e1e08d4 but I have absolutely no idea if this will work 🤷♂️ I don't really understand the |
Adds
--plaintextflag which allows sendinge-mails in plaintext with SMTP method.
Not implemented for the Resend method.
Fixes (partially?) #115