fix(compat): more accurate behavior of SGR 21 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michał Kotowski <[email protected]>
caarlos0
approved these changes
Dec 16, 2024
aymanbagabas
added a commit
to charmbracelet/x
that referenced
this pull request
Jan 27, 2025
Supersedes: charmbracelet/sequin#43 Supersedes: #309
aymanbagabas
added a commit
to charmbracelet/x
that referenced
this pull request
Jan 27, 2025
Supersedes: charmbracelet/sequin#43 Supersedes: #309
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes required if change for SGR 21 in
x/ansi(charmbracelet/x#309) accepted without further changes.Adapts description of SGR 21 to match the most common implementation.
(Somewhat related to my related inquiry in #27 about dealing with conflicting implementations).