-
Notifications
You must be signed in to change notification settings - Fork 291
fix: source #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: source #567
Conversation
does this do the same as #551 ? |
Oh, didn't see that one. I think so, but let me see. This one is a bit tricky, so better have a closer look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just tested it, seems to work! thanks for the pr!
i have one small remark only :)
Co-authored-by: Carlos Alexandro Becker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
see also #604 |
Expands the parsed
Source
command instead of re-parsing it later.Works for me so far, but not sure if this is the right approach.
fix #566