Skip to content

fix: source #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 26, 2025
Merged

fix: source #567

merged 5 commits into from
Mar 26, 2025

Conversation

rsteube
Copy link
Contributor

@rsteube rsteube commented Jan 4, 2025

Expands the parsed Source command instead of re-parsing it later.

Works for me so far, but not sure if this is the right approach.

fix #566

@rsteube rsteube marked this pull request as ready for review January 4, 2025 23:25
@caarlos0
Copy link
Member

caarlos0 commented Jan 6, 2025

does this do the same as #551 ?

@rsteube
Copy link
Contributor Author

rsteube commented Jan 6, 2025

Oh, didn't see that one. I think so, but let me see.
Looks like the logged prefix might get lost there though.

This one is a bit tricky, so better have a closer look.

@caarlos0 caarlos0 requested a review from a team as a code owner March 26, 2025 16:33
@caarlos0 caarlos0 requested review from bashbunni and removed request for a team March 26, 2025 16:33
Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just tested it, seems to work! thanks for the pr!

i have one small remark only :)

@caarlos0 caarlos0 changed the title fix source fix: source Mar 26, 2025
rsteube and others added 3 commits March 26, 2025 17:57
@caarlos0 caarlos0 added the bug Something isn't working label Mar 26, 2025
@caarlos0 caarlos0 assigned caarlos0 and unassigned caarlos0 Mar 26, 2025
Copy link
Member

@bashbunni bashbunni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@bashbunni bashbunni merged commit fd38bed into charmbracelet:main Mar 26, 2025
9 checks passed
caarlos0 added a commit that referenced this pull request Mar 27, 2025
@caarlos0
Copy link
Member

see also #604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source: format settings have no effect
4 participants