Skip to content
This repository has been archived by the owner on Jun 24, 2021. It is now read-only.

Show users the RESV reason when they attempt to join channels that are resv'd #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TheWug
Copy link

@TheWug TheWug commented Mar 23, 2014

I changed form_str(ERR_BADCHANNAME) to allow the author to specify the message used displayed to users, which is now:

"%s :Illegal channel name (%s)"

I keep hearing how nice it would be if charybdis did this so I figured why not .

Change RESV to show users the resv reason when attempting to join a resv'd channel (via the 479 numeric)
Add canned messages to other uses of 479
@jillest
Copy link
Contributor

jillest commented Apr 21, 2014

Hmm, existing resv reasons may not be suitable for display to normal users. Perhaps display something to a user only if there is an explicit oper reason and/or make it configurable?

@TheWug
Copy link
Author

TheWug commented Apr 22, 2014

I considered the possibility of handling it the same way klines are handled, with a pipe character seperating the user-visible reason and the oper-visible reason. Since there's interest in this behavior I'll try to update it tonight to include that.

…om user reason)

Applied same change to numeric 432 (ERR_ERRONEUSNICKNAME), given when a user tries to use a resv'd nickname
Updated the oper help text for resv to reflect the new syntax
@TheWug
Copy link
Author

TheWug commented Apr 24, 2014

Oper reasons for RESVS are implemented. Additionally, I applied the same sort of change to numeric 432 (ERR_ERRONEUSNICKNAME) which is displayed when a user attempts to NICK to a resv'd nick.

Memory-safety is easy to assess (I null out the pipe seperator byte, append the reason, and then restore it when broadcasting to users, no intermediate buffers are used)

@sariyamelody
Copy link
Contributor

What is the status on this?

@kaniini
Copy link
Contributor

kaniini commented Dec 10, 2014

Are legacy RESVs converted to be oper-only? If so, I would be willing to merge it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants