Fix/forground notification callback#406
Open
mohit5189 wants to merge 5 commits intochat-sdk:masterfrom
Open
Conversation
Author
|
Hi team Can we merge this please. |
Author
|
Hi Team Can you please help for this? |
Author
|
Hi Team Can you please help to fix this issue... Our app foreground push handling is blocked because of this and should be issue in another apps too which have chat as submodule only. |
Author
|
Hi Team any help here... If we adding SDK in existing app that use forground push, This code stop push sending in our app. ChatPushHandler won't get any push in this case and our app functionality is blocked. It should be case for many users who are not having chat only as feature, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK was not sending any push event to app in case if app was in Foreground. I added change which will make sure that: