Skip to content

[18.0][MIG] sale_stock_mto_as_mts_orderpoint_product_variant: Migration to 18.0 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] sale_stock_mto_as_mts_orderpoint_product_variant: Migration to 18.0 #3

wants to merge 4 commits into from

Conversation

chaule97
Copy link
Owner

@chaule97 chaule97 commented Jan 9, 2025 •
edited
Loading

@chaule97 chaule97 force-pushed the 18.0-mig-sale_stock_mto_as_mts_orderpoint_product_variant branch 3 times, most recently from cbaf773 to 3030e8b Compare January 10, 2025 08:19
@chaule97 chaule97 force-pushed the 18.0-mig-sale_stock_mto_as_mts_orderpoint_product_variant branch from 3030e8b to 71bbb6e Compare January 10, 2025 08:22
xaviedoanhduy
xaviedoanhduy approved these changes Jan 13, 2025
View reviewed changes
Copy link

@xaviedoanhduy xaviedoanhduy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

sale_stock_mto_as_mts_orderpoint_product_variant/models/product_product.py Outdated
self._archive_orderpoints_on_mto_removal()
return res

@api.depends("product_tmpl_id.route_ids")
Copy link

@xaviedoanhduy xaviedoanhduy Jan 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove this code, i see that route_ids are already stored in this module:

stock-logistics-workflow/stock_product_variant_mto/models/product_product.py

Line 29 in d557475

store=True,

sale_stock_mto_as_mts_orderpoint_product_variant/models/sale_order_line.py
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 1 question: is it really necessary?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, after I fixed sale_stock_mto_as_mts_orderpoint, it is not necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@xaviedoanhduy xaviedoanhduy xaviedoanhduy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chaule97 @xaviedoanhduy @mmequignon