-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: GOG-Galaxy #241
base: master
Are you sure you want to change the base?
Add: GOG-Galaxy #241
Conversation
"installer": { | ||
"script": [ | ||
"$file = \"$dir\\$fname\"", | ||
"Expand-InnoArchive -Path $file -ExtractDir '{%ALLUSERSPROFILE}' -DestinationPath $env:ALLUSERSPROFILE", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this? Since it does not satisfy the concept of the bucket All apps in this repository should NOT require elevated privileges while installation.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This instruction did not cause elevated privileges, actually, at least there's no pop-up window for elevated privileges.
There are four directories after unpacking with innounp: {%ALLUSERSPROFILE}
, {app}
, {fonts}
, {tmp}
.
Where {%ALLUSERSPROFILE}
is designed to be under the $env:ALLUSERSPROFILE
path (C:\ProgramData
)
If the path is not organized in this way, the program will report an error:
Essential components needed to start GOG Galaxy are missing or incorrectly configured. if this continues, please reinstall the application.
I didn't find a solution, I think that's how they write the program.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This instruction did not cause elevated privileges, actually, at least there's no pop-up window for elevated privileges.
C:\ProgramData
requires the Administrators role to write, you'll not see UAC if you're the Administrator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To check current user whether is Administrator or not:
[System.Security.Principal.WindowsIdentity]::GetCurrent().Name -in (Get-LocalGroupMember -Group "Administrators").Name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I'm the administrator.
So what should we do? GOG will read components in $env:ALLUSERSPROFILE
, the program cannot accept a parameter to change this behavior.
"uninstaller": { | ||
"script": "Write-Host \"`nNote:`n------`nYou need to delete `$env:ALLUSERSPROFILE\\GOG.com yourself.`n\"" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this section, uninstall, I mean.
Delete the directory will cause elevated privileges with pop-up window, so I think users should be reminded to delete it.
I still haven't found a solution to the problem. |
Added manifest:
Local installation test passed, it is not certain that the
checkver
andautoupdate
modules are effective, but there should be?