Fix 2fa login #1544
Merged
Fix 2fa login #1544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bloom frontend
|
||||||||||||||||||||||||||||||
| Project |
Bloom frontend
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 10m 51s |
| Commit |
|
| Committer | Anna Hughes |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
11
|
Skipped
|
0
|
Passing
|
100
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make and why did you make them?
Attempted to fix issues related to setting up MFA as a superuser. The edge case that we're fixing is when a user attempts to verify their phone number for MFA but requires reauthentication due to it being a while since they logged in.
We have added a reauthentication flow (reenter password) and attempted to fix a related error with the recaptcha being rendered several times.
Due to firebase SMS not working in development envs, we need to release this to prod to test it thoroughly, including trying to trigger the reauthentication flow.
Did you run tests? Share screenshot of results:
Tests added but couldnt be completed due to recatcha being triggered/required before sending verification. some basic UI flow tests were added