This repository was archived by the owner on Oct 9, 2024. It is now read-only.
Increase z-index of panel #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbieaverill
approved these changes
Nov 26, 2021
|
Do tooltips, dropdowns, and loading indicators still work in panels? |
jaepass
force-pushed
the
bugfix/panel-z-index
branch
from
a07ebc1 to
6758306
Compare
|
Alright so latest push fixes loading indicators to only have z-index if it has a background, which we mostly use for full page loads, otherwise it would not have a z-index. All tooltips, dropdowns work as expected. Example of loading indicator without bg displaying as expected. |
ScopeyNZ
approved these changes
Nov 26, 2021
|
I'm always nervous about these arbitrary z-index changes. Should be pretty obvious if this negatively affects something else though. |
|
Yeahup for sure, will keep an eye out TA |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With https://github.com/chec/dashboard/pull/1488 fix, the slideout panel would be under the nav header and sidebar. This PR fixes that.
Fixes #565 as well