This repository was archived by the owner on Oct 9, 2024. It is now read-only.
Removing hover, focus and active from tags #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the blog post in the marketing site uses them as links. We could refactor this to use something else. |
|
@robbieaverill yea that's weird, they're just wrapped in a link. |
|
Opened PR fixing in chec/marketing-chec#714 |
robbieaverill
approved these changes
Nov 27, 2021
|
cc @kvisca |
|
@robbieaverill sorry about that, I'll update that right now. |
kvisca
force-pushed
the
bug/chectag-hover-state
branch
from
e1d2ea2 to
aa9ac2a
Compare
robbieaverill
approved these changes
Nov 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized that this isn't actually a button so I removed the hover states outright. Issue confused me but I can't find an instance where these are clickable as a router link.
Closes #555