Skip to content
This repository was archived by the owner on Oct 9, 2024. It is now read-only.

[CHEC-1932] Add new borders, background, and shadow props #588

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

jaepass
Copy link
Contributor

@jaepass jaepass commented Dec 6, 2021

  • Add new borders style, remove unused vertical and horizontal styles
  • Add background as prop
  • Add shadow as prop

Follow up PR with marketing card Contentful model edits
Reimplement dashboard and marketing site with new props

@linear
Copy link

linear bot commented Dec 6, 2021

CHEC-1931 Flesh out docs landing page from marketing page content model

We have decided to recreate the docs landing page (currently under /docs) as a marketing page where it will be the point of entry page to navigate to the SDK, API, technical blogs, starter projects etc.

This task is to go into Contentful and try to design out the new docs landing page with as many of the existing block content models we have and to make a note of what edits we need to make to these models or whether we need to add new ones.

A/Cs

  • Create a new mock Content page in Contentful that includes all the models we need
  • Make note of what edits we need to make for existing content models etc. the card blocks need to have new configuration for adding shadows

@jaepass jaepass force-pushed the feature/card-props branch from ef9e889 to 57107f5 Compare December 6, 2021 21:34
@jaepass jaepass changed the title [CHEC-1931] Add new borders, background, and shadow props [CHEC-1932] Add new borders, background, and shadow props Dec 6, 2021
@linear
Copy link

linear bot commented Dec 6, 2021

CHEC-1932 Overhaul marketing cards and add docs card designs

Based on CHEC-1931, we need to overhaul all the marketing cards in Contentful's content model and implement them in code. Some of the current docs card designs do not exist in marketing pages right now ex. the short height and long width ones, cards with hovers, feature image etc. This task is to add new card designs by adding new configuration fields in the content model 'Marketing | Block | Card'.

A/Cs:

  • Add new field configuration in Marketing | Block | Card
  • Make the necessary edits in the marketing project code

@jaepass jaepass force-pushed the feature/card-props branch from 57107f5 to a64bf96 Compare December 6, 2021 23:40
@robbieaverill
Copy link
Contributor

image

Do you want to set a lighter text colour when using the dark background, or leave that up to the implementor?

Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

@jaepass jaepass force-pushed the feature/card-props branch from fdfe69e to d662735 Compare December 7, 2021 00:47
@jaepass
Copy link
Contributor Author

jaepass commented Dec 7, 2021

I think we can leave this up to the implementor as we have transparent as a background option too

@jaepass jaepass force-pushed the feature/card-props branch from d662735 to 29d0845 Compare December 7, 2021 01:01
@robbieaverill robbieaverill merged commit 87d8d29 into master Dec 7, 2021
@robbieaverill robbieaverill deleted the feature/card-props branch December 7, 2021 01:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants