feat: add support for TCP checks [sc-23026]#124
Merged
Conversation
sorccu
requested review from
Antoine-C,
maxigimenez,
pilimartinez and
shiini2
as code owners
sorccu
deleted the
simokinnunen/sc-23026/add-tcp-check-support-to-go-sdk-used-by-the
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for TCP Checks.
Not my proudest work but I stuck to the existing style. The whole SDK needs an overhaul.
A minimal integration test is included. It actually found an issue in the API (
checkTypeis required for the PUT endpoint), but I added a reasonable workaround for it.PR checks are failing because configured secrets point to some unknown Checkly account that does not have TCP checks enabled, apparently.
Affected Components
Style
go fmtNotes for the Reviewer
New Dependency Submission