Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Conversation

@guolau
Copy link
Contributor

@guolau guolau commented Mar 4, 2025

Affected Components

  • Content & Marketing
  • Pricing
  • Test
  • Docs
  • Learn
  • Other

Pre-Requisites

  • Code is linted (npm run lint)

Notes for the Reviewer

Updated the API check overview page according to the check overview page facelift proposal.

Summary of changes:

  • Updated title and display title for clarity
  • Added an introduction
  • Edited text for clarity and brevity in a few places
  • Fixed outdated info (screenshots, broken links, deprecated features, etc)
  • Restructured the headings to better match the API create/edit pages
  • Added CLI example
  • Added Resources section

@guolau guolau requested a review from ragog March 4, 2025 22:31
@guolau guolau requested a review from tnolet as a code owner March 4, 2025 22:31
@vercel
Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
checklyhq-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2025 8:56pm

tnolet
tnolet previously approved these changes Mar 6, 2025
Copy link
Member

@tnolet tnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ragog ragog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guolau looking good, let's polish a couple of things and ship. Left comments.

Start as you mean to go on. Pick a sensible name, something that other members of your team are going to understand. A meaningful name will not only help you and others identify your checks within Checkly, but it will help provide better a better alerting experience if your checks fall into an alert state.
Tags can relate your checks together, they also determine which checks are shown on your public [dashboards](/docs/dashboards/).
![http request](/docs/images/api-checks/overview-name-tag.png)
You can use these checks to verify that:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guolau let's make clear that these are examples (i.e. more can be done than what is listed here)

* Your endpoint is properly authenticating requests.

**2. The HTTP request**
If your endpoint is unresponsive or fails assertions, the check will trigger any configured alerts.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guolau considering this is an overview page, let's link back to the alerting overview page to help our first time users.


Our [time limits](limits) are customisable, sometimes API's can be slow, but not broken. We call that **degraded**. We let you specify when an API check should be marked as **degraded** and when it should be marked as **failed**.
![response times](/docs/images/api-checks/overview-response-time.png)
Sometimes APIs can be slow, but not broken. We call this **degraded**. You can set [response time limits](/docs/api-checks/limits/) to specify when an API check should be marked as **degraded** and when it should be marked as **failed**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guolau we're only using bold text in this section. Can we either stick to plain text or highlight this differently, maybe with ``?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guolau let's use a screenshot where "Run request" is not greyed out

![schedule](/docs/images/api-checks/overview-schedule.png)
The above example defines:
- The basic check properties like `name`, `activated` etc.
- The HTTP method `GET` the `url`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guolau this is phrased weirdly. Perhaps "The HTTP method GET and the target url of the request?

coderabbitai[bot]
coderabbitai bot previously approved these changes Mar 17, 2025
@guolau guolau dismissed stale reviews from coderabbitai[bot] and tnolet via b027419 March 17, 2025 20:53
@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2025

Walkthrough

The update revises the API checks documentation. The document title changed from “Monitoring APIs with Checks” to “Getting started with API checks.” The introduction and section headings were reformatted and reorganized, with content rewritten for clarity. New sections such as "Retries & alerting," "Testing," and a "CLI example" have been added, including a corresponding TypeScript code snippet that illustrates API check configuration using Checkly constructs.

Changes

File Change Summary
site/.../api-checks/_index.md • Updated document title and display title.
• Rewritten introduction explaining API checks and their purpose.
• Reformatted section headings with descriptive titles.
• Reorganized content sections (e.g., "Name and tags," "HTTP request," etc.).
• Added new sections for "Retries & alerting," "Testing," and a "CLI example" with an embedded code snippet.
hello-api.check.ts • New CLI example added showing API check configuration using Checkly constructs, including properties such as name, activation status, frequency, HTTP request parameters, and assertions.

Suggested reviewers

  • tnolet
  • serverless-mom
  • Dgiordano33

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (5)
site/content/docs/api-checks/_index.md (5)

46-48: Setup and Teardown Scripts Description

The explanation is detailed and informative. Consider hyphenating "last minute processing" to "last-minute processing" since it acts as a compound adjective modifying "processing":

-Setup scripts allow you to do last minute processing of test data and request options.
+Setup scripts allow you to do last-minute processing of test data and request options.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~48-~48: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ... scripts Setup scripts allow you to do last minute processing of test data and request opt...

(EN_COMPOUND_ADJECTIVE_INTERNAL)


56-63: Assertions List Formatting

The unordered list under the Assertions section currently uses dashes. To conform with our markdown style guidelines, please change them to asterisks:

- - The HTTP status code returned from the API
- - Something missing or required within the response body
- - A specific response header
- - A specific response time
+ * The HTTP status code returned from the API
+ * Something missing or required within the response body
+ * A specific response header
+ * A specific response time
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

60-60: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)


61-61: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)


62-62: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)


63-63: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)


67-69: Scheduling & Locations Formatting

The Scheduling & Locations section provides key information; however, the sentence on line 69 could be clearer. Consider adding a comma before "and" for improved readability:

-If you don't select more than one location and you've disabled retrying checks from the same location, we will pick a random location when retrying checks.
+If you don't select more than one location, and you've disabled retrying checks from the same location, we will pick a random location when retrying checks.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~69-~69: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ... you don't select more than one location and you've disabled retrying checks from th...

(COMMA_COMPOUND_SENTENCE)


106-109: CLI Example List Style

The list explaining what the CLI example defines is currently using dashes. Please update these to asterisks to maintain consistent markdown list styling:

- - The basic check properties like `name`, `activated` etc.
- - The `GET` HTTP method and target `url` of the request.
- - An array of assertions to assert the HTTP response status is correct.
+ * The basic check properties like `name`, `activated` etc.
+ * The `GET` HTTP method and target `url` of the request.
+ * An array of assertions to assert the HTTP response status is correct.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

107-107: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)


108-108: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)


109-109: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)


113-119: Next Steps Section Refinement

The “Next steps” section is very useful; however, on line 116, the term "commonly-used" would read better as "commonly used" without the hyphen:

-* Store commonly-used or sensitive data, like usernames and auth tokens, in [environment variables and secrets](/docs/api-checks/variables/).
+* Store commonly used or sensitive data, like usernames and auth tokens, in [environment variables and secrets](/docs/api-checks/variables/).
🧰 Tools
🪛 LanguageTool

[uncategorized] ~116-~116: The hyphen in commonly-used is redundant.
Context: ...](/guides/monitoring-as-code/). * Store commonly-used or sensitive data, like usernames and a...

(ADVERB_LY_HYPHEN_FIX)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c8dcb9f and b027419.

⛔ Files ignored due to path filters (10)
  • site/assets/docs/images/api-checks/overview-alerting.png is excluded by !**/*.png
  • site/assets/docs/images/api-checks/overview-assertions.png is excluded by !**/*.png
  • site/assets/docs/images/api-checks/overview-check-overview.png is excluded by !**/*.png
  • site/assets/docs/images/api-checks/overview-create-check.png is excluded by !**/*.png
  • site/assets/docs/images/api-checks/overview-http.png is excluded by !**/*.png
  • site/assets/docs/images/api-checks/overview-locations.png is excluded by !**/*.png
  • site/assets/docs/images/api-checks/overview-name-tag.png is excluded by !**/*.png
  • site/assets/docs/images/api-checks/overview-response-time.png is excluded by !**/*.png
  • site/assets/docs/images/api-checks/overview-schedule.png is excluded by !**/*.png
  • site/assets/docs/images/api-checks/overview-scripts.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • site/content/docs/api-checks/_index.md (2 hunks)
🧰 Additional context used
🪛 LanguageTool
site/content/docs/api-checks/_index.md

[uncategorized] ~48-~48: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ... scripts Setup scripts allow you to do last minute processing of test data and request opt...

(EN_COMPOUND_ADJECTIVE_INTERNAL)


[uncategorized] ~69-~69: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ... you don't select more than one location and you've disabled retrying checks from th...

(COMMA_COMPOUND_SENTENCE)


[uncategorized] ~116-~116: The hyphen in commonly-used is redundant.
Context: ...](/guides/monitoring-as-code/). * Store commonly-used or sensitive data, like usernames and a...

(ADVERB_LY_HYPHEN_FIX)

🪛 markdownlint-cli2 (0.17.2)
site/content/docs/api-checks/_index.md

60-60: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)


61-61: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)


62-62: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)


63-63: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)


107-107: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)


108-108: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)


109-109: Unordered list style
Expected: asterisk; Actual: dash

(MD004, ul-style)

🔇 Additional comments (13)
site/content/docs/api-checks/_index.md (13)

2-3: Title and Display Title Update

The title and display title have been updated to clearly reflect the page’s new focus on getting started with API checks. Please ensure these values are consistently referenced elsewhere in the documentation.


16-16: Improved Introduction

The introductory sentence now effectively explains that API checks work by sending HTTP requests to verify response speed and correctness. This enhancement improves clarity for first-time users.


18-18: Updated Screenshot Reference

The updated image reference should help users visualize the API check overview page. Verify that the image exists at the provided path and reflects the current UI.


20-23: Clear API Check Examples

The bullet list clearly outlines concrete examples (e.g., verifying a 200 status code, JSON schema, proper authentication). This upgrade improves understandability.


27-27: New ‘Creating an API check’ Section

The addition of the "Creating an API check" header provides a clear entry point for users, guiding them where to begin when setting up their own checks.


29-29: Updated Create-Check Screenshot

The screenshot for creating an API check now reflects the latest UI. Please confirm that the image accurately represents the current creation process.


31-35: Enhanced 'Name and Tags' Section

The revised explanation emphasizes the importance of meaningful naming and tagging, which will help in both identification and alerting.


38-42: HTTP Request Section Clarity

The HTTP request section now clearly explains the configuration options—such as body data, headers, and query parameters—which is valuable for users setting up custom API checks.


52-54: Response Time Limits Explanation

The description in this section clearly communicates the concept of degraded performance versus outright failure, which will help users set realistic performance thresholds.


73-77: Retries & Alerting Section

The updated section on retry strategies and alerting channels is concise and informative. Users will benefit from the clearer guidance on notification options.


79-81: Testing Section Enhancement

The Testing section now clearly communicates that checks can be run as E2E tests either locally or through CI/CD pipelines, which is very useful for deployment validation.


83-87: CLI Example Introduction

This section now provides a succinct introduction to the CLI example, combining contextual information with a clear call to action for developers to try it out.


89-104: CLI Code Example Quality

The TypeScript code snippet is well-formatted and demonstrates how to define an API check with Checkly constructs (including the use of assertions). This is a strong addition for users who prefer a code-centric approach.

@guolau guolau requested a review from ragog March 17, 2025 21:02
Copy link
Contributor

@ragog ragog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guolau guolau merged commit 2e3a801 into main Mar 18, 2025
7 checks passed
@guolau guolau deleted the guolau/update-api-checks-overview branch March 18, 2025 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants