Pascal/fix flaky e2e tests #1287
Open
+27
−295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pascal-Delange
commented
Jan 19, 2026
| @@ -1,288 +0,0 @@ | |||
| { | |||
Contributor
Author
There was a problem hiding this comment.
was accidentally added before it was added to .gitignore ?
Pascal-Delange
force-pushed
the
pascal/fix-flaky-e2e-tests
branch
from
d3ce9f9 to
6b8d104
Compare
Add data-hydrated attribute to body element after React hydration completes. E2E tests now wait for this attribute before interacting with UI elements, preventing race conditions where clicks happen before event handlers are attached. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Pascal-Delange
force-pushed
the
pascal/fix-flaky-e2e-tests
branch
from
6b8d104 to
9e14427
Compare
ChibiBlasphem
approved these changes
Jan 20, 2026
Contributor
ChibiBlasphem
left a comment
ChibiBlasphem
left a comment
There was a problem hiding this comment.
LGTM, I hope this was the root cause of the issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix flaky tests by waiting for app hydration.