feat: Improve OAuth Token Handling and Logging #474
Merged
+165
−46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Improve OAuth Token Handling and Logging
Description:
This PR enhances OAuth authentication by improving token validation, adding logging, refactoring OAuth models, and ensuring better error handling.
Key Changes:
OAuth Enhancements:
Improved Logging (
@Slf4j
) inOAuthAccessToken
:Refactored
OAuthAccessToken
:tokenType
field.tokenType
andexpirationDate
.Better Error Handling in
OAuthSdkCredentials
:Refactored
OAuthServiceResponse
:tokenType
field.Testing Improvements:
Unit Tests for OAuth Handling (
OAuthSdkCredentialsTest
):Mocked HTTP Responses for OAuth API Calls:
Mockito
to simulate different OAuth responses.null access_token
,error: invalid_client
, etc.).Impact:
Notes:
OAuthAccessToken
andOAuthServiceResponse
.