Skip to content

Commit

Permalink
infra: fix name of upstream file to be in kebab-case
Browse files Browse the repository at this point in the history
  • Loading branch information
romani committed Mar 4, 2023
1 parent 632f53a commit 7be213a
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions checkstyle-tester/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ and comparing the abstract syntax trees of both branches.
### Check Regression Report

To generate the check difference report, you must separate the modules and settings in the
[`checkstyle_checks.xml`](https://github.com/checkstyle/checkstyle/blob/master/config/checkstyle_checks.xml)
[`checkstyle-checks.xml`](https://github.com/checkstyle/checkstyle/blob/master/config/checkstyle-checks.xml)
configuration file, found in the checkstyle repository, into separate configuration files
(this helps avoid 'out of memory' errors).
The best way to separate the checks is to determine which typically produce the most violations,
Expand All @@ -266,7 +266,7 @@ then separating the rest into files with roughly ten checks each.
You may modify all the checks that depend on external files to use default settings. **For each
of the configuration files, you should use the [`my_check.xml`]
(https://github.com/checkstyle/contribution/blob/master/checkstyle-tester/my_check.xml)
file as a base**, and add the checks from `checkstyle_checks.xml` to it. Then `diff.groovy`
file as a base**, and add the checks from `checkstyle-checks.xml` to it. Then `diff.groovy`
should be run on all projects in `projects-to-test-on.properties`, using the `diff.groovy`
script once for each configuration file.
[See instructions above]
Expand Down
2 changes: 1 addition & 1 deletion checkstyle-tester/checks-nonjavadoc-error.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<module name="Checker">
<!--
this config is a copy of
https://github.com/checkstyle/checkstyle/blob/master/config/checkstyle_checks.xml
https://github.com/checkstyle/checkstyle/blob/master/config/checkstyle-checks.xml
with update to global severity=ignore to catch only exceptions.
Some other checks are commented out to speed up execution time.
Expand Down
8 changes: 4 additions & 4 deletions misc/build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<delete file="${target.dir}/cachefile" />

<property name="checkstyle.pattern.todo" value="NOTHingWillMatCH_-"/>
<property name="check.config" location="checkstyle_checks.xml"/>
<property name="check.config" location="checkstyle-checks.xml"/>
<checkstyle failonviolation="false" config="${check.config}">
<fileset dir="src/checkstyle"
includes="**/*.java,**/*.properties"
Expand Down Expand Up @@ -78,15 +78,15 @@
classpathref="run.classpath">
<sysproperty key="checkstyle.allow.tabs" value="yes"/>
<arg value="-c"/>
<arg file="checkstyle_checks.xml"/>
<arg file="checkstyle-checks.xml"/>
<arg value="src/testinputs/com/puppycrawl/tools/checkstyle/InputSimple.java"/>
</java>
<java classname="com.puppycrawl.tools.checkstyle.Main"
fork="yes"
dir="."
classpathref="run.classpath">
<arg value="-c"/>
<arg file="checkstyle_checks.xml"/>
<arg file="checkstyle-checks.xml"/>
<arg value="-r"/>
<arg file="src/checkstyle/com/puppycrawl/tools/checkstyle/api"/>
</java>
Expand All @@ -101,7 +101,7 @@
<delete file="${target.dir}/cachefile" />

<property name="checkstyle.pattern.todo" value="NOTHingWillMatCH_-"/>
<property name="check.config" location="checkstyle_checks.xml"/>
<property name="check.config" location="checkstyle-checks.xml"/>
<checkstyle config="${custom.config}" file="${file.to.check}">
<formatter type="plain"/>
<formatter type="xml" toFile="${target.dir}/cs_errors.xml"/>
Expand Down
2 changes: 1 addition & 1 deletion patch-diff-report-tool/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<checkstyle.version>10.8.0</checkstyle.version>
<checkstyle.configLocation>https://raw.githubusercontent.com/checkstyle/checkstyle/checkstyle-${checkstyle.version}/config/checkstyle_checks.xml</checkstyle.configLocation>
<checkstyle.configLocation>https://raw.githubusercontent.com/checkstyle/checkstyle/checkstyle-${checkstyle.version}/config/checkstyle-checks.xml</checkstyle.configLocation>
<maven.plugin.antrun.version>3.1.0</maven.plugin.antrun.version>
<maven.compiler.source>11</maven.compiler.source>
<maven.compiler.target>11</maven.compiler.target>
Expand Down

0 comments on commit 7be213a

Please sign in to comment.