-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of config bundles with extra configuration files #214
Comments
Proporsed solution: we can make extra file in Example folder of this repo: ATTENTION: |
@relentless-pursuit , we missed all config folder
Please update extractor to place it in this folder too |
https://github.com/checkstyle/test-configs/tree/main/RegexpHeader/Example2
requires extra config file
<property name="headerFile" value="config/java.header"/>
(folder is not required we can update example to be justjava.header
)test-configs/RegexpHeader/Example2/config.xml
Line 20 in 6700899
Even we add it 24f8a55 like this.
it will not be downloaded, as we download only 2 files from test-configs repo.
and inside regression-report.yml of checkstyle we copy them to required folder for report generation.
https://github.com/checkstyle/checkstyle/blob/5eca53ce31f48b61fae0612a2092815009772b48/.github/workflows/regression-report.yml#L388-L394
We need to find a way to download all required files/folders and copy them to execution folder by regression-report.yml .
This feature will help a lot of modules, as several of them have ability to keep configs in separate files.
The text was updated successfully, but these errors were encountered: