feat: An option to disable triggers validation #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes introduce an option that disables triggers validation
The motivation behind the option is aimed mainly at test environments. Validation is great, but it works in an asynchronous manner, which gets in the way of sandboxed repos (
Ecto.Adapters.SQL.Sandbox.mode(Repo, :manual)
)So, when running tests, you can hit the following error:
(DBConnection.OwnershipError) cannot find ownership process for #PID
From my understanding, that happens because the validator tries to return a database connection to the pool, but isn't authorized to do that. Mostly because it was spawned outside test cases.
The
validate_triggers?
makes it possible to skip validation in tests and avoid the above error altogether.That said, please let me know if you have any other ideas to avoid the mentioned scenario. I'm more than willing to cooperate on this.
Also, thank you for such a nice library! 🙇