🧪 Mv GHA pip deps cache mgmt to in-tree actions #739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
force-pushed
the
maintenance/in-house-pip-deps-gha-cache-control
branch
6 times, most recently
from
86e80f3 to
1b675f4
Compare
The upstream `actions/setup-python` has rudimentary support for cache management but it's rather limited. It also has bugs in caching [[1]]. Having own reusable cache computation bit gives us better level of control, letting us make cache depend on specific Python runtime features. [1]: actions/setup-python#1034
webknjaz
force-pushed
the
maintenance/in-house-pip-deps-gha-cache-control
branch
from
1b675f4 to
a299b23
Compare
webknjaz
added a commit
to webknjaz/ansible--awx-plugins
that referenced
this pull request
Feb 26, 2025
This action generalizes a piece of code for ABI-sensitive cache management that we were copying around. It also handles corner cases better than `actions/setup-python`. Refs: * https://github.com/marketplace/actions/cache-python-deps * https://github.com/re-actors/cache-python-deps * aio-libs/frozenlist#622 * aio-libs/frozenlist#633 * actions/setup-python#1034 * cherrypy/cheroot#739
webknjaz
added a commit
to sphinx-contrib/sphinxcontrib-towncrier
that referenced
this pull request
Feb 27, 2025
This action generalizes a piece of code for ABI-sensitive cache management that we were copying around. It also handles corner cases better than `actions/setup-python`. Refs: * https://github.com/marketplace/actions/cache-python-deps * https://github.com/re-actors/cache-python-deps * aio-libs/frozenlist#622 * aio-libs/frozenlist#633 * actions/setup-python#1034 * cherrypy/cheroot#739
webknjaz
added a commit
to ansible/awx_plugins.interfaces
that referenced
this pull request
Mar 4, 2025
This action generalizes a piece of code for ABI-sensitive cache management that we were copying around. It also handles corner cases better than `actions/setup-python`. Refs: * https://github.com/marketplace/actions/cache-python-deps * https://github.com/re-actors/cache-python-deps * aio-libs/frozenlist#622 * aio-libs/frozenlist#633 * actions/setup-python#1034 * cherrypy/cheroot#739
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❓ What kind of change does this PR introduce?
📋 What is the related issue number (starting with
#)N/A
❓ What is the current behavior? (You can also link to an open issue here)
Cache in
actions/setup-pythonis buggy on Windows.❓ What is the new behavior (if this is a feature change)?
This attempts to work around the problem by managing it manually through in-tree composite actions.
📋 Other information:
Ref: actions/setup-python#1034
📋 Contribution checklist:
(If you're a first-timer, check out
this guide on making great pull requests)
the changes have been approved
and description in grammatically correct, complete sentences
This change is