Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: simplify CMakeLists.txt #421

Merged
merged 14 commits into from
Jan 2, 2024
Merged

build: simplify CMakeLists.txt #421

merged 14 commits into from
Jan 2, 2024

Conversation

kanru
Copy link
Member

@kanru kanru commented Jan 1, 2024

remove linker hacks and remove symbol version nodes

This is more compatible with existing releases and future releases
generated by rustc directly.

Copy link

codecov bot commented Jan 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f32c5b) 79.16% compared to head (194acfb) 79.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #421      +/-   ##
==========================================
+ Coverage   79.16%   79.94%   +0.77%     
==========================================
  Files          56       55       -1     
  Lines       10603    10500     -103     
==========================================
  Hits         8394     8394              
+ Misses       2209     2106     -103     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kanru kanru force-pushed the refactor/symbol-versioning branch from d2550ae to f8ada25 Compare January 1, 2024 16:10
@kanru kanru force-pushed the refactor/symbol-versioning branch 5 times, most recently from 1f517f2 to 5b35fe9 Compare January 1, 2024 17:24
@kanru kanru force-pushed the refactor/symbol-versioning branch from 31dc1df to e019063 Compare January 1, 2024 23:57
@kanru kanru force-pushed the refactor/symbol-versioning branch from bb01db2 to a50271f Compare January 2, 2024 00:21
@kanru kanru added this pull request to the merge queue Jan 2, 2024
Merged via the queue into master with commit 42c252c Jan 2, 2024
@kanru kanru deleted the refactor/symbol-versioning branch January 2, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants