Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Allow space key for pagination regardless of space_is_s… #598

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

kanru
Copy link
Member

@kanru kanru commented Jul 13, 2024

…elect_key mode. Fixes #581

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.52%. Comparing base (53e2641) to head (194b570).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #598      +/-   ##
==========================================
- Coverage   89.52%   89.52%   -0.01%     
==========================================
  Files          39       39              
  Lines        8516     8515       -1     
==========================================
- Hits         7624     7623       -1     
  Misses        892      892              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kanru kanru added this pull request to the merge queue Jul 13, 2024
@kanru kanru added this to the v0.9.0 milestone Jul 13, 2024
Merged via the queue into master with commit 4766ad9 Jul 13, 2024
12 checks passed
@kanru kanru deleted the issue581 branch July 13, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow using space as next page key even if "space as selection" option is not enabled
1 participant