Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): implement SimpleEngine which doesn't use intelligent ph… #604

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

kanru
Copy link
Member

@kanru kanru commented Jul 14, 2024

…rasing

Fixes #556, Fixes #9

Copy link

codecov bot commented Jul 14, 2024

Codecov Report

Attention: Patch coverage is 81.70732% with 15 lines in your changes missing coverage. Please review.

Project coverage is 89.45%. Comparing base (5e0cf21) to head (e92a4a8).

Files Patch % Lines
capi/src/io.rs 53.33% 7 Missing ⚠️
src/conversion/chewing.rs 86.79% 7 Missing ⚠️
src/editor/mod.rs 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #604      +/-   ##
==========================================
- Coverage   89.52%   89.45%   -0.08%     
==========================================
  Files          39       39              
  Lines        8508     8580      +72     
==========================================
+ Hits         7617     7675      +58     
- Misses        891      905      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kanru kanru added this pull request to the merge queue Jul 14, 2024
Merged via the queue into master with commit 30f38c2 Jul 14, 2024
10 of 12 checks passed
@kanru kanru deleted the simple-mode branch July 14, 2024 12:59
@kanru kanru added this to the v0.9.0 milestone Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

支援簡單模式 簡單注音模式
1 participant