fix: resolve docker context when running as root via launchd#81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When installed via Homebrew, the binary runs as a root LaunchDaemon which has no
~/.docker/config.json. This meant docker context resolution always failed, and there was no fallback. So even if you were using the default docker socket, it wouldn't use it.This fixes the issue by:
/dev/console, then pointsDOCKER_CONFIGto their docker config directory before resolving the contextclient.FromEnvwhich respectsDOCKER_HOSTand then the default socketTest plan
sudo ./docker-mac-net-connectworks (normal sudo, HOME preserved)sudo -i $(pwd)/docker-mac-net-connectworks (simulates launchd with root HOME)