-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(WIP) Release/accessibility phase1 #434
Draft
st3phhays
wants to merge
23
commits into
main
Choose a base branch
from
release/accessibility-phase1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes some general accessibility enhancements like increased spacing, link styles, and other minor changes to improve the overall accessibility of choco-theme.
This updates a lot of the colors in choco-theme to ensure that they are accessible. This includes changes to the structure of the scss as well, to separate it out into folders for better organization.
This includes some general accessibility enhancements like increased spacing, link styles, and other minor changes to improve the overall accessibility of choco-theme.
This updates a lot of the colors in choco-theme to ensure that they are accessible. This includes changes to the structure of the scss as well, to separate it out into folders for better organization.
This allows multiple Toast notifications to stack on top of each other. They are only removed from the dom after the `hide` callback is triggered. This gives the user the ability to see all of the notifications that have been triggered.
This removes the jQuery Duallistbox library in favor of the Select extension from datatables.js.
This updates a lot of the colors in choco-theme to ensure that they are accessible. This also enhances some components to take advantage of color, or add indicators other than color.
This updates the .stylelintignore file and addresses any stylelint errors. This should not change the outcome of CSS, but enforces code style.
This ensures the .btn-sm class is not effected with a minimum height like normal buttons.
This adjust the selectors used for the left side navigation to remove the main element before. This will make it compatible with the new HTML structure.
st3phhays
force-pushed
the
release/accessibility-phase1
branch
from
January 15, 2025 11:19
bc8089c
to
6ff76ec
Compare
While this doesn't remove the jQuery Duallistbox library yet, this is the start of being able to do so. The changes here in combination with others in the repository allow for similar functionality, yet in an accessible way. This introduces the fuse.js library to help with search.
st3phhays
force-pushed
the
release/accessibility-phase1
branch
from
January 16, 2025 18:31
672e4d0
to
9da4468
Compare
Increase checkbox size to 25px by 25px.
…s-and-radios (#436) Increase size of checkboxes to 25px by 25px
This removes the jQuery Duallistbox library and all the things related to it. This library is no longer being used and needs removed.
With the increased size of checkboxes, they were somewhat being smooshed together if they were stacked. Increasing the margin bottom on them helps separate them some and look better in general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
TBD.
Motivation and Context
TBD.
Testing
TBD.
Operating Systems Testing
TBD.
Change Types Made
Change Checklist
Related Issue
TBD.