Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#3291) Update Chocolatey.NuGet.Client libraries to 3.4.2 #3288

Merged
merged 1 commit into from
Aug 2, 2023
Merged

(#3291) Update Chocolatey.NuGet.Client libraries to 3.4.2 #3288

merged 1 commit into from
Aug 2, 2023

Conversation

AdmiringWorm
Copy link
Member

@AdmiringWorm AdmiringWorm commented Jul 31, 2023 •
edited
Loading

Description Of Changes

To fix a bug in licensed extension when downloading packages and the cache location is set to a restricted folder, there was a need to update Chocolatey.NuGet.Client and pull in the changes to Chocolatey CLI. This PR makes the necessary changes for this.

Motivation and Context

See description

Testing

See the testing step in the NuGet.Client PR: chocolatey/NuGet.Client#47

Operating Systems Testing

  • Windows 10
  • Windows Server 2022

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.
  • Version Update

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Fixes #3291

@AdmiringWorm AdmiringWorm mentioned this pull request Aug 1, 2023
Closed
5 tasks
gep13
gep13 requested changes Aug 2, 2023
View reviewed changes
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the credits.md file for this bump in the dependency?

@AdmiringWorm AdmiringWorm changed the title (maint) Bump nuget libraries (#3291) Update Chocolatey.NuGet.Client libraries to 3.4.2 Aug 2, 2023
@gep13 gep13 changed the base branch from develop to hotfix/2.2.1 August 2, 2023 16:46
gep13
gep13 approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 marked this pull request as ready for review August 2, 2023 16:50
@gep13 gep13 requested a review from corbob August 2, 2023 16:50
corbob
corbob approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@corbob corbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. Just standing up a VM to run through the testing before merging.

@AdmiringWorm @corbob
(chocolatey#3291) Update Chocolatey.NuGet.Client libraries to 3.4.2
40fe353 
To fix a bug in licensed extension when downloading packages and the
cache location is set to a restricted folder, there was a need to update
Chocolatey.NuGet.Client and pull in the changes to Chocolatey CLI.
This PR makes the necessary changes for this.
@corbob corbob merged commit 9b234cf into chocolatey:hotfix/2.2.1 Aug 2, 2023
4 checks passed
@AdmiringWorm AdmiringWorm deleted the nuget-update branch August 3, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corbob corbob corbob approved these changes

@gep13 gep13 gep13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to do non-elevated operations when cachelocation is set to a restricted directory
3 participants
@AdmiringWorm @gep13 @corbob