Skip to content

(build) Add templated notifications to all build configurations #3469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

Windos
Copy link
Member

@Windos Windos commented Jun 19, 2024

Description Of Changes

This PR makes each build configuration in the TeamCity KTS file reference a template containing standard Slack notification configuration, which applies said configuration to the build configuration without having to duplicate it in each.

Motivation and Context

Enables standard notification configuration across all build configurations in this project.

Testing

This has been tested by pointing a development TeamCity instance at the branch from which this merge request is originating.

Operating Systems Testing

N/A

Change Types Made

Build configuration change (non-breaking)

* [ ] Bug fix (non-breaking change).
* [ ] Feature / Enhancement (non-breaking change).
* [ ] Breaking change (fix or feature that could cause existing functionality to change).
* [ ] Documentation changes.
* [ ] PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

N/A

@Windos Windos requested a review from gep13 June 19, 2024 01:54
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 20d5a4f into chocolatey:develop Jun 27, 2024
4 checks passed
@gep13
Copy link
Member

gep13 commented Jun 27, 2024

@Windos thank you for getting this added!

@gep13 gep13 added 4 - Done Build Automation NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product. labels Jun 27, 2024
@gep13 gep13 added this to the 2.4.0 milestone Jun 27, 2024
@vexx32
Copy link
Member

vexx32 commented Nov 12, 2024

🎉 This issue has been resolved in version 2.4.0 🎉

The release is available on:

@vexx32 vexx32 removed the 4 - Done label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Released Build Automation NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants