Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#3318) Fix -WhatIf tests #3554

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

vexx32
Copy link
Member

@vexx32 vexx32 commented Nov 7, 2024

Description Of Changes

Fix some small test errors

Motivation and Context

A couple of small errors in the -WhatIf tests showed up on teamcity, so this should hopefully fix those.

Testing

Testing in test kitchen

Operating Systems Testing

Win 2016 & 2019

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

#3318

@vexx32 vexx32 force-pushed the fix-whatif-tests branch 2 times, most recently from c1208e8 to 27e6d4f Compare November 7, 2024 21:01
vexx32 and others added 2 commits November 7, 2024 17:09
A couple of small errors in the -WhatIf tests showed up on teamcity, so
this should hopefully fix those.
The Test Kitchen environment has both `hermes` and `hermes-all` enabled.
This results in a duplication of the warning message. This disables all
the sources and then enables just the `hermes` source. # Please enter
the commit message for your changes. Lines starting
Copy link
Member

@corbob corbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me. These work now when I run them locally. I'll wait for the TeamCity tests to finish before merging them.

@corbob corbob marked this pull request as ready for review November 8, 2024 01:16
@corbob corbob merged commit 8e7582f into chocolatey:develop Nov 8, 2024
5 checks passed
@vexx32 vexx32 deleted the fix-whatif-tests branch November 8, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants