Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(maint) Remove chocolatey.benchmark and chocolatey.powershell from MSI build #3557

Merged
merged 1 commit into from
Nov 8, 2024
Merged

(maint) Remove chocolatey.benchmark and chocolatey.powershell from MSI build #3557

merged 1 commit into from
Nov 8, 2024

Conversation

corbob
Copy link
Member

@corbob corbob commented Nov 8, 2024

Description Of Changes

Remove building extra packages from the MSI configuration.

Motivation and Context

Newly added projects were causing the MSI build to fail. This removes all projects for all MSI configurations except the chocolatey.install project.

Testing

  1. Tag a commit locally with git commit 2.4.0
  2. Run ./build.official.bat
  3. Verify that there is an MSI created in code_drop/Artificacts

Operating Systems Testing

Windows 10

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

N/A

@corbob
(maint) Update MSI configuration to only build MSI
dc726c6 
Update the MSI build configuration to only build the MSI instead of
building unnecessary projects.
@corbob corbob added BuildAutomation NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product. labels Nov 8, 2024
@corbob corbob added this to the 2.4.0 milestone Nov 8, 2024
@corbob corbob requested a review from vexx32 November 8, 2024 20:15
@corbob corbob self-assigned this Nov 8, 2024
vexx32
vexx32 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and is working again in builds. Thanks for sorting that out! 💜

@vexx32 vexx32 merged commit 104d7c3 into chocolatey:release/2.4.0 Nov 8, 2024
5 checks passed
@corbob corbob deleted the fix-msi-build branch November 8, 2024 21:54
@vexx32
Copy link
Member

vexx32 commented Nov 12, 2024

🎉 This issue has been resolved in version 2.4.0 🎉

The release is available on:

@vexx32 vexx32 removed the 4 - Done label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vexx32 vexx32 vexx32 approved these changes

Assignees

@corbob corbob

Labels
5 - Released BuildAutomation NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product.
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@corbob @vexx32