(maint) Finish the 2.4.0 release by merging master to develop #3562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MSI was erroneously creating the C:\ProgramData\Chocolatey directory. This caused the install script to fail silently and not actually install Chocolatey. This removes the directory from the install and just lets the install script install to the default location.
The MSI was generating a C:\Tools directory, but never actually using it. This commit removes the Tools directory from the install so it is never created.
Since these files are not copied to the output folder, and instead are added to the choco.exe as resources, we need to additional verify each script file from the source location, in the same way that they are selected when they are being signed.
This is an attempt to ensure that any changes to our dependencies, whether that is: * changes to NuGet packages through packages.config files * updates to custom assemblies which are not tracked through NuGet packages * updates to custom executables/assemblies which are added directly to the Chocolatey CLI Chocolatey Packages Are trakced and updated properly. By making these files/folder owned by the new @chocolatey-credits-reviewers group, it means that a member of that group will be flagged on any PR's that we raised that contain these files.
This updates the tests to validate that the version number is not output in the Info log messages only. There are some debug log messages that may contain a similar version number as they report the user agent being used, this prevents them from being erroneously picked up.
The debug log is used in a lot of places when we don't want the user to see the output, but we want it available. At the moment it is not consistent about what we do when they select debug and limit output. It has been decided at the moment to remove these tests as they are now breaking by us emitting the user agent to the debug log. A follow up issue #3555 has been created to determine what we want for behaviour when limit output and debug is selected.
(#3526) Fix failing integration tests
Update the MSI build configuration to only build the MSI instead of building unnecessary projects.
(maint) Remove chocolatey.benchmark and chocolatey.powershell from MSI build
Licensed does queries in the background before / while normal commands are running, so we can end up with multiple user-agent debug lines. Resolve this by just looking at the most recently-outputted user agent, as these should all look the same (and if not, the last one should be the one from the actual command run).
(#3526) Fix user agent test for licensed
Automatic update from the current latest docs in the docs repo.
(release) 2.4.0
|
@vexx32 thanks for getting this done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Back-merging changes from master to develop.
Motivation and Context
Finishing out the 2.4.0 release.
Testing
N/A
Operating Systems Testing
N/A
Change Types Made
Change Checklist
Related Issue
N/A