(maint) Correct some typos and fix some tests

[corbob]

Description Of Changes

1. Remove the mention of choco list -lo from the NuSpec file.
2. Update an upgrade all test to ensure that it does not report failure if a newer Chocolatey version is available on internal repositories.
3. Use PowerShell instead of powershell.
4. Fix Get-EnvironmentVariableNames tests to run.
5. Update Vagrant box used for building and running tests to use the chocolatey/test-environment box.

Motivation and Context

1. Local Only on the list command was removed in 2.0, and is an error now.
2. When tests are running as we come up towards a release, we end up with reports of failures of the upgrade all command because for instance it will be testing version 2.4.1-beta-20241204, but because of the way the builds work, CI will have build and published to our repository version 2.5.0-alpha-20241204 which is deemed an upgrade for the pre-release version being tested.
3. The correct casing is PowerShell.
4. Due to a misconfiguration, these tests were not running, and would start failing in Pester 6.x.
5. The previous box hasn't been updated for several years. We also encourage testing on the chocolatey/test-environment box, so running out tests on it makes sense.

Testing

• Run through Test Kitchen
• Run tests through vagrant up in the tests directory. (There are some known failures here, the important thing is that the majority of them run successfully)

Operating Systems Testing

• Windows Server 2016
• Windows Server 2019
• Windows Server 2022

Change Types Made

• Bug fix (non-breaking change).
• Feature / Enhancement (non-breaking change).
• Breaking change (fix or feature that could cause existing functionality to change).
• Documentation changes.
• PowerShell code changes.
• Pester test changes.

Change Checklist

• Requires a change to the documentation.
• Documentation has been updated.
• Tests to cover my changes, have been added.
• All new and existing tests passed?
• PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

N/A - These are things that I found doing the recent 2.4.1 release.

[corbob]

This PR is draft until I can run the tests through Test Kitchen. I also need to update the testing steps to validate that the test failure is gone, but will need to think on the best way to do that.

[corbob]

A few things I need to update about this before it's out of WIP. Adding here so I don't forget:

• There's a few places we say powershell instead of PowerShell
• There are some tests that fail in the local vagrant environment, but not Test Kitchen. Would like to get those updated to pass everywhere.
• There is one test file that fails with Pester 6.x alpha build due to a ForEach variable being null. This will need to be addressed.

  choco/tests/pester-tests/powershell-commands/Get-EnvironmentVariableNames.Tests.ps1

  Line 14 in 89a5634

  It 'Gets the complete list of environment variables in the <Scope> scope"' -ForEach $variables {

  $variables is not defined here.
• Vagrant box used for building and running tests hasn't been updated in a while.

[corbob]

@gep13 I was looking at some of these tests, and although I wanted to get a few more things in here, I've paired this down to things that I think will help you with the next release (in particular the upgrade all test fix).

(I've added this PR to the document for our weekly meeting if we want to discuss it)

[gep13]

LGTM!

[gep13]

@corbob thank you for getting these updates done! I will get this merged in once the CI builds are finished.

[gep13]

@corbob thank you for getting these updates done!