-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating quickmodel with more options and to use parser function. #97
Conversation
Merging John's changes in master into quickmodel branch.
Okay, so it turns out that the things that I thought would be easy to get done before the more advanced changes above took a bit longer than expected. What HAS been done here:
The other things will have to wait for now, but were added to #72, see discussion on #91 for more about 'adding Mehtap's plate format'. Mergeable if tests are passing. |
Looks like there is a py3 issue with the JSON serialization: The failure seems to be caused by the
|
My best guess is that the error we see:
is due to a 0 that is not a normal Python
|
I can't tell if it's |
I think this should fix it, but wasn't able to reproduce the error in a python3 environment, so not sure. Will just have to wait! |
Checks are passing. Merging. |
Updating quickmodel with a few more options and so that it now uses
parser.py
, which I've been working on for Greg and Mehtap to be usable outside of quickmodel.Options to add: