fix: return early if click targets element outside of root node#13
Open
m90 wants to merge 1 commit intochoojs:masterfrom
m90:click-outside
Open
fix: return early if click targets element outside of root node#13m90 wants to merge 1 commit intochoojs:masterfrom m90:click-outside
m90 wants to merge 1 commit intochoojs:masterfrom
m90:click-outside
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to choojs/choo#704
It looks like clicks outside the given root node would still be handled as the check of
nanohref/index.js
Line 22 in 80c11c4
would never apply until the traversal has reached an anchor element.
Two questions/concerns from my side:
rootbeing an anchor element itself, a click on this element would also be skipped right now. This is the case with and without the fix, yet I am not sure if this is considered ok or should be fixed?