Docs corrections #72
Merged
Docs corrections #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@achou11 these look really good, thanks for all your work! -- I'm a bit hesitant to merge right now though because our deploy pipeline is broken, which means that merging will take the website offline haha. But leaving this as "approved & should be merged as soon as we get the pipeline fixed"! |
Contributor
Author
|
haha no problem! thanks for reviewing :) |
Member
|
choo 6.10 broke it by changing stores to lazy initialisation. hypha initialises routes inside a store. choojs/bankai#452 would fix it on the bankai end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some grammatical edits to the docs sections. If I wasn't super sure about the correctness of something, I left it alone - so my edits aren't super strict or thorough. I primarily looked to change anything that made the readability a little awkward for me.
I really love reading all of the content for the docs and learning more about how to use Choo! Hoping to make more contributions in the future :)