Fix AVAX, include AVAXC #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to BIP-0044 and SLIP-0044, AVAX is a reference to the Avalanche X- & P- chains. This adds a validator to strip away the optional ID (X- or P-) and then validates using the BIP173 validator. This is a breaking change but the correct behaviour.
The Avalanche C-Chain is Ethereum compatible but it is part of the spec that it can be prepended with an ID of C-. This validator strips that ID before passing to the Ethereum validator.
|
The error in Travis looks like a problem with Node 18 and Travis, not the changes here. |
|
Sorry to ping you @christsim, is there any chance I can get a review on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current AVAX implementation is actually for the C-Chain, which is actually AVAXC according to SLIP-0044.
These changes are breaking but accomplish two things:
A couple questions I have:
dist/folder committed as well?References: