Skip to content

Conversation

@Vishnunkumar
Copy link

Description of changes

Test plan

  • Test cases not added yet, will add.

Documentation Changes

  • Docstrings are added in the code, will raise another PR for the docs repository.

@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@tazarov
Copy link
Contributor

tazarov commented Apr 24, 2024

@Vishnunkumar, thanks for the PR. I think this is duplicate of another ongoing PR - #1723

@Vishnunkumar
Copy link
Author

@Vishnunkumar, thanks for the PR. I think this is duplicate of another ongoing PR - #1723

Yeah the only difference is in the model being used, we can abandon this if this seems redundant

@tazarov
Copy link
Contributor

tazarov commented Apr 29, 2024

@Vishnunkumar, is it ok to close this PR?

@Vishnunkumar
Copy link
Author

Vishnunkumar commented Apr 30, 2024

@Vishnunkumar, is it ok to close this PR?

Yeah we can close this PR, I will look into the mentioned PR once it is merged and will look to contribute if possible

@tazarov tazarov closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants