Skip to content

voyageai embedding function #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

voyageai embedding function #2171

wants to merge 1 commit into from

Conversation

alxfed
Copy link

@alxfed alxfed commented May 9, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • voyageai embedding function
  • New functionality
    • Voyage AI is an embedding service recommended by Anthropic.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? - does not apply. Do we need to make documentation changes in the docs repository? - No

Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chroma ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 1:27am

Copy link

github-actions bot commented May 9, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@tazarov
Copy link
Contributor

tazarov commented May 9, 2024

@alxfed, thanks for the effort. We already have a PR for the Python version of the Voyage AI—#1327. I think we can get the other PR merged asap and close this one.

@tazarov tazarov added the duplicate This issue or pull request already exists label May 9, 2024
@alxfed
Copy link
Author

alxfed commented May 9, 2024

OK

@alxfed alxfed closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants