Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: fix binary search impl of LimitOperator #3489

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

codetheweb
Copy link
Contributor

Description of changes

This has been materializing as a flaky test, but is an actual correctness bug. Reproduced in a Python test and tracked down to this operator.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Added test was previously failing.

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

n/a

Sorry, something went wrong.

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Sorry, something went wrong.

@codetheweb codetheweb force-pushed the bug-limit-binary-search-off-by-one branch from 979bfd5 to ca18e20 Compare January 14, 2025 23:05
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@codetheweb codetheweb force-pushed the bug-limit-binary-search-off-by-one branch from ca18e20 to 69c4d73 Compare January 14, 2025 23:19
@HammadB
Copy link
Collaborator

HammadB commented Jan 15, 2025

Could we hardcode the repro that caused this if it was a prop test?

@codetheweb
Copy link
Contributor Author

Could we hardcode the repro that caused this if it was a prop test?

Added

@codetheweb codetheweb enabled auto-merge (squash) January 15, 2025 02:21
@codetheweb codetheweb disabled auto-merge January 15, 2025 17:40
@codetheweb codetheweb merged commit babded1 into main Jan 15, 2025
78 checks passed
@codetheweb codetheweb deleted the bug-limit-binary-search-off-by-one branch January 15, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants