-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ENH] Add resource_name to SysDB tenants table #4730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Add resource_name Field to SysDB Tenants Table with Unique Index This PR introduces a new, nullable TEXT field called Key Changes: Affected Areas: This summary was automatically generated by @propel-code-bot |
@@ -12,7 +12,7 @@ data "external_schema" "gorm" { | |||
|
|||
env "dev" { | |||
src = data.external_schema.gorm.url | |||
dev = "postgres://localhost:5432/chroma?sslmode=disable" | |||
dev = "postgres://chroma:chroma@localhost:5432/chroma?sslmode=disable" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found that this was necessary to get the migration to run properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will setter methods to set this come after?
@HammadB yes, wanted to keep this just to migration |
Cool can we stack the rest of the change and merge them down together so we can make sure our changes all make sense together? |
48caba8
to
67d8771
Compare
1fff500
to
e6f6417
Compare
rust/sqlite/migrations/sysdb/00010-tenant-resource-name.sqlite.sql
Outdated
Show resolved
Hide resolved
Note: in order to unblock this, we're no longer including the SQLite SysDB migration. After hours of debugging, the rust bindings prop test failure continues to elude. Will follow up with it. cc @codetheweb |
6d6dd56
to
1fc07be
Compare
Description of changes
Summarize the changes made by this PR.
resource_name
, totenants
table on SysDB. This is a globally unique identifier for the tenant, so adds a unique index (when not null) as well. It is meant to be a human-readable identifier.Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?