[BLD]: fix Go test flakes

[codetheweb]

Description of changes

These changes seem to fix most causes of the Go tests flaking. Ran 70 times with no flake, whereas the flake rate seemed to be 5-20% prior to these changes.

Test plan

How are these changes tested?

• Tests pass locally with pytest for python, yarn test for js, cargo test for rust

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[codetheweb]

this is never hit, but realized any error here was swallowed during testing

[propel-code-bot]

Improve Go Test Reliability by Reducing Flakiness in CI

This PR addresses Go test flakes by forcing sequential test execution in the Makefile, disabling the Ryuk container cleanup utility during CI runs, and adding stricter error handling for container startup in test database setup. The changes primarily target conditions causing race conflicts and resource contention with Docker-based database containers in CI environments, aiming to make Go tests more reliable.

Key Changes:
• Go tests are now run sequentially by adding '-p 1' to the test command in the Makefile, accompanied by explanatory comments on the cause of flakiness.
• CI workflow disables Testcontainers' Ryuk component, which was identified as a source of test flakiness.
• Error handling improved in Go test database setup: errors from starting a Postgres test container are now checked and will panic on failure.

Affected Areas:
• go/Makefile (test targets)
• go/pkg/sysdb/metastore/db/dbcore/core.go (test DB setup)
• .github/workflows/_go-tests.yml (GitHub Actions/CI for Go)

This summary was automatically generated by @propel-code-bot

[propel-code-bot]

[BestPractice]

There's a missing error check after calling container.Ports(). Similar to how you've started properly handling the error from postgres2.RunContainer(), you should also check for errors when getting the ports.

[eculver]

Cool. I guess we might want to keep an eye on this a bit. The tests are already pretty fast and this doesn't seem to slow them down, presumably because there just aren't a ton of them? I guess it would still be nice to know why there are flakes when running in parallel, but since it doesn't "cost" much to run them sequentially, then who cares.