Skip to content

[TST] Make random batch sizes in prop tests #4774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[TST] Make random batch sizes in prop tests #4774

wants to merge 3 commits into from

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Jun 6, 2025

Description of changes

Testing if randomly sized batches break things.

Test plan

CI.

Documentation Changes

N/A

Copy link
Contributor

propel-code-bot bot commented Jun 6, 2025

Introduce Randomized Batch Sizes in Batch Utilities for Property Testing

This PR updates the batch utility logic to split input data into batches of random sizes (rather than consistently sized slices) for testing whether variable batch sizes impact downstream processing. The batching function is modified to use a random size (within the allowed maximum) during the batch split process, aligning with the stated intent to evaluate robustness against non-uniform batches.

Key Changes:
• Adds 'import random' to support randomized batch sizes.
• Modifies 'create_batches' to generate batches of random sizes between 1 and the API's max batch size when splitting input greater than the maximum.
• Removes old logic for fixed-size batching.

Affected Areas:
• chromadb/utils/batch_utils.py

This summary was automatically generated by @propel-code-bot

Copy link

github-actions bot commented Jun 6, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@rescrv
Copy link
Contributor Author

rescrv commented Jun 6, 2025

Do not merge this as it breaks the client batching lib.

offset = 0
if len(ids) > max_batch_size:
while offset < len(ids):
batch_size = random.randint(1, max_batch_size):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[CriticalError]

There's a syntax error in your code - the line with random.randint() has a colon at the end which is invalid Python syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant