Skip to content

[TST]: fix test filtering flake caused by wildcard handling change #4775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Jun 6, 2025

Description of changes

#4402 caused test_filtering.py to start flaking because the test assertions around _ handling were not updated.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Copy link

github-actions bot commented Jun 6, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb codetheweb marked this pull request as ready for review June 6, 2025 02:06
@codetheweb codetheweb requested a review from itaismith June 6, 2025 02:06
Copy link
Contributor

This PR updates the filtering logic in 'test_filtering.py' to remove outdated handling of '%' and '_' as wildcards, aligning the tests with recent changes in the underlying implementation. The flakiness caused by regex-based matching for these wildcards is resolved by reverting to simple substring checks.

This summary was automatically generated by @propel-code-bot

@codetheweb codetheweb enabled auto-merge (squash) June 6, 2025 16:44
@codetheweb codetheweb merged commit 3052d13 into main Jun 6, 2025
72 checks passed
@codetheweb codetheweb deleted the tst-fix-flake-doc-filter-wildcard branch June 6, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants