-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[ENH] Add muvera and colBERT support to python client #5744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
15304a1 to
998da94
Compare
|
Add This PR introduces MuVERA-based fixed-dimensional encoding (FDE) to convert ColBERT multivector outputs into single-vector embeddings consumable by Chroma. A full NumPy implementation ( Key Changes• New file Affected Areas• This summary was automatically generated by @propel-code-bot |
| return "cosine" | ||
|
|
||
| def supported_spaces(self) -> List[Space]: | ||
| return ["cosine", "l2", "ip"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it actually support all of these?
| return "cosine" | ||
|
|
||
| def supported_spaces(self) -> List[Space]: | ||
| return ["cosine", "l2", "ip"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check if l2 actually works with muvera
jairad26
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it auto-normalize? double check

Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustMigration plan
Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?
Observability plan
What is the plan to instrument and monitor this change?
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?