-
Notifications
You must be signed in to change notification settings - Fork 2k
[ENH] Load blocks given keys under P0 priority #6006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Load blocks given keys under P0 priority #6006
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Renamed block loading helpers and elevated priority to This PR replaces the Key Changes• Renamed record-segment helper methods from Affected Areas• rust/segment/src/blockfile_record.rs This summary was automatically generated by @propel-code-bot |
## Description of changes _Summarize the changes made by this PR._ - Improvements & Bug fixes - Rename `prefetch_*` to `load_*` to better indicate its usage. Prefetch is for lower priority data warmup, and should be used in a fire and forget fashion. Load higher priority and could be blocked on. - Make `load_blocks` use `P0` priority instead of `P1` when fetching blocks. Previously prefetch use `P1` priority and led to long tail latency on log materialization. - New functionality - N/A ## Test plan _How are these changes tested?_ - [ ] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Migration plan _Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?_ ## Observability plan _What is the plan to instrument and monitor this change?_ ## Documentation Changes _Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs section](https://github.com/chroma-core/chroma/tree/main/docs/docs.trychroma.com)?_
This PR cherry-picks the commit bbaa6c9 onto release/2025-12-05. If there are unresolved conflicts, please resolve them manually. Co-authored-by: Macronova <[email protected]>

Description of changes
Summarize the changes made by this PR.
prefetch_*toload_*to better indicate its usage. Prefetch is for lower priority data warmup, and should be used in a fire and forget fashion. Load higher priority and could be blocked on.load_blocksuseP0priority instead ofP1when fetching blocks. Previously prefetch useP1priority and led to long tail latency on log materialization.Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustMigration plan
Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?
Observability plan
What is the plan to instrument and monitor this change?
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?