Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.10] Allow usage of XPath in waitForElement #544

Merged
merged 10 commits into from
Sep 8, 2023
Merged

[1.10] Allow usage of XPath in waitForElement #544

merged 10 commits into from
Sep 8, 2023

Conversation

jhoopmann
Copy link
Contributor

@jhoopmann jhoopmann commented Sep 6, 2023 •
edited
Loading

@jhoopmann jhoopmann changed the title jhoopmann/allow xpath wait for element [1.10] jhoopmann/allow xpath wait for element Sep 6, 2023
@jhoopmann jhoopmann changed the title [1.10] jhoopmann/allow xpath wait for element [1.10] Allow usage of XPath in waitForElement Sep 6, 2023
@jhoopmann jhoopmann marked this pull request as ready for review September 6, 2023 08:52
@jhoopmann
Copy link
Contributor Author

fixxed private const access

@enricodias enricodias linked an issue Sep 7, 2023 that may be closed by this pull request
Allow usage of XPathSelector in Page::waitForElement #539
Open
@GrahamCampbell GrahamCampbell merged commit d45e130 into chrome-php:1.10 Sep 8, 2023
12 checks passed
@GrahamCampbell
Copy link
Member

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enricodias enricodias enricodias approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow usage of XPathSelector in Page::waitForElement
3 participants
@jhoopmann @GrahamCampbell @enricodias