views: fix crashes due dangling pointers #4072
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When closing the browser, the native_delegate back reference might still point to the CefBrowserPlatformDelegateNativeAura object, while it's already been destroyed (via UserData destruction), leading the dangling pointer detection to crash the browser. Calling from CefBrowserPlatformDelegateChromeViews::BrowserDestroyed() back into the view delegate in order to clear that reference. Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
Make sure we don't have any dangling pointers to already destroyed objects. Even if they aren't actually accessed anymore, that's still causing the reference checker to panic (thus crashing the application). Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
Collaborator
|
This implementation detail should not be exposed via the public API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
views: callback for clearing native_delegate_
When closing the browser, the native_delegate back reference might still
point to the CefBrowserPlatformDelegateNativeAura object, while it's
already been destroyed (via UserData destruction), leading the dangling
pointer detection to crash the browser.
Calling from CefBrowserPlatformDelegateChromeViews::BrowserDestroyed()
back into the view delegate in order to clear that reference.
views: ChildWindowDelegate: clear native_delegate_ on destruct
Make sure we don't have any dangling pointers to already destroyed objects.
Even if they aren't actually accessed anymore, that's still causing the
reference checker to panic (thus crashing the application).