-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [sc-10649] Expose Metrics in Ghost #201
base: main
Are you sure you want to change the base?
Conversation
pending some discussions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the tor-proxy
chart is not used any more since we handle the deployment of tor/onion resources using the CRD's. please remove the tor-proxy changes from the pr.
Then to get ghost metrics port, we can update this
- port:
number: 8888
backend:
service:
name: ghost
port:
number: {{ .Values.ghost.service.ports.webapi.port }}
- port:
number: 9999
backend:
service:
name: {{ include "validator.fullname" . }}-metrics
port:
number: 9090
oh and we would need to update the metrics service |
|
@@ -17813,7 +17813,7 @@ spec: | |||
imagePullPolicy: Always | |||
livenessProbe: | |||
httpGet: | |||
path: /healthz | |||
path: /livez |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because healthz
is deprecated
@@ -169,9 +169,6 @@ ghost: | |||
# - path: /webapi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is very unlikely that we would expose webapi
here.
As an example, it's OK, but the metrics
below are configured elswhere and keeping them here would confuse folks.
Trying to expose new service through TOR, but we need to discuss more.